TP2000-1463 Support SQLite dump on DBT Platform #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both django-dotenv and python-dotenv rely upon the same `import dotenv`, causing a conflict when dependended-upon packages rely upon python-dotenv. Therefore use the more popular and ubiquitous python-dotenv package, reducing the likelihood of conflict.
Add support to generate and execute SQLite migration source files under a system's temporary file storage directory. Copilot-based service deployments run under /tmp while all other deployments do not do so by default - the env var SQLITE_MIGRATIONS_IN_TMP_DIR may be set to True to force /tmp directory behaviour.
dalecannon
approved these changes
Sep 17, 2024
exporter/sqlite/runner.py
Outdated
| file.unlink() | ||
|
|
||
|
|
||
| def try_as_octal(decimal: int): |
There was a problem hiding this comment.
Is this function still intended to be used?
There was a problem hiding this comment.
It was being used and now it's not. Now removed.
paulpepper-trade
deleted the
TP2000-1463--sqlite-dump-incompatible-with-dbt-platform
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TP2000-1463 Support SQLite dump on DBT Platform
Why
The SQLite dump process fails on DBT Platform deployments because of file write access restrictions under an application’s deployment directory.
Both django-dotenv and python-dotenv rely upon the same
import dotenv, causing a conflict when dependended-upon packages rely upon python-dotenv.What
This PR:
Adds support to generate and execute SQLite migration source files under a system's temporary file storage directory. Copilot-based service deployments run under
/tmp, while all other deployments do not do so by default - the env varSQLITE_MIGRATIONS_IN_TMP_DIRmay be set toTrueto force/tmpdirectory behaviour.Switches from using the django-dotenv package to the more ubiquitous python-dotenv package to load
.envfile variables into the applications shell environment. This increases the chances of other packages that rely upon python-dotenv to work with Tamato.Checklist